Skip to content

Adding support for InsertManyOptions for insert and insertAll methods #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
infoShare wants to merge 2 commits into from
Closed

Adding support for InsertManyOptions for insert and insertAll methods #4273

infoShare wants to merge 2 commits into from

Conversation

@infoShare
Copy link

@infoShare infoShare commented Jan 16, 2023 •
edited
Loading

Adding support for InsertManyOptions for insert and insertAll methods on ReactiveMongoTemplate and MongoTemplate
Using writer on MongoTemplate.doInsertAll (which wasn't used)
Closes #4252

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).**

Clean PR @christophstrobl regarding #4252

infoShare and others added 2 commits January 16, 2023 14:09
@infoShare
Merge pull request #1 from spring-projects/main
1c10761 
Merge changes
Adding support for InsertManyOptions for insert and insertAll methods…
beb71d2 
… on ReactiveMongoTemplate and MongoTemplate

Using writer on MongoTemplate.doInsertAll (which wasn't used)

Closes #4252
@infoShare infoShare mentioned this pull request Jan 16, 2023
Closed
4 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 16, 2023
@christophstrobl christophstrobl added the for: team-attention An issue we need to discuss as a team to make progress label Jan 19, 2023
@christophstrobl
Copy link
Member

christophstrobl commented Jan 19, 2023

Thanks for creating the PR. Performance wise there is no major difference between the driver API for insertMany and bulk.insert which makes me curious if (related to the missing bulk ops in the reactive support (#2821)) it would make more sense to have ReactiveBulkOperations instead of adding yet another round of methods to the template.
Let me take this to the team as well.

@christophstrobl
Copy link
Member

christophstrobl commented May 8, 2023

We've added support for reactive bulk operations. Closing this one as it has been superseded by #4342.

@christophstrobl christophstrobl added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we need to discuss as a team to make progress labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: superseded An issue that has been superseded by another

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider adding options parameter to ReactiveMongoTemplate.insertAll

3 participants

@infoShare @christophstrobl @spring-projects-issues